Draft
Conversation
Member
enricozb
approved these changes
Aug 30, 2024
src/run.cu
Outdated
| int result = mkdir(name.buf, mode); | ||
| free(name.buf); | ||
|
|
||
| if (result) { |
Contributor
There was a problem hiding this comment.
Can we keep the var names the same? In the C runtime you called this status.
nicolas-abril
requested changes
Aug 30, 2024
src/run.cu
Outdated
Comment on lines
968
to
969
| book->ffns_buf[book->ffns_len++] = (FFn){"DELETE_FILE", io_delete_file}; | ||
| book->ffns_buf[book->ffns_len++] = (FFn){"DELETE_DIRECTORY", io_delete_directory}; |
Member
There was a problem hiding this comment.
Following the convention of using the C/unix name for these functions, it would be better to call them "RM" and "RMDIR".
Also, if we're using "rmdir" we definitely should not also use "delete_directory", either go with one style or the other.
HVM in general prefers short names
Member
|
I've also added some comments on the specs for this issue, I think we need to change the interfaces a little |
nicolas-abril
requested changes
Aug 30, 2024
imaqtkatt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the branch name it implements 3 new functions related to the removal of files or directories and the creation of directories